#4965: Fix issues with gradle pre-6.4 #4995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OK, as the NB16 vote is already pending, I will probably rebase & target the cc: @neilcsmith-net |
lkishalmi
force-pushed
the
gradle/internal-611
branch
from
ce04774
to
7990cea
Compare
lkishalmi
pushed a commit
to lkishalmi/netbeans
that referenced
this pull request
Nov 27, 2022
* Fix apache#4965: Avoid NPE: return null for no supplier. * Improve compatibility for Gradle < 6.4
lkishalmi
pushed a commit
that referenced
this pull request
Dec 6, 2022
lkishalmi
pushed a commit
that referenced
this pull request
Dec 15, 2022
Chris2011
pushed a commit
to Chris2011/netbeans
that referenced
this pull request
Dec 15, 2022
* Fix apache#4965: Avoid NPE: return null for no supplier. * Improve compatibility for Gradle < 6.4
pepness
pushed a commit
to pepness/incubator-netbeans
that referenced
this pull request
Jan 9, 2023
* Fix apache#4965: Avoid NPE: return null for no supplier. * Improve compatibility for Gradle < 6.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4965. There are two issues, one NPE: simply the supplier parameter is not checked (can be null) before it is asked to supply a default. Next, another call to internal API, this time introduced by Gradle 6.4 was found - reported just as a warning, not affecting rest of the operation.
Added a unit test that gradle 6.1.1 loads a default project.