Cleanup few remaining raw type List warnings.. #5004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonihele
reviewed
Nov 29, 2022
enterprise/web.core/src/org/netbeans/modules/web/core/api/JspColoringData.java
Outdated
Show resolved
Hide resolved
|
There are lot of these old Hashtables. I think they should be evaluated whether synchronization is really needed. If it is needed, changing them to ConcurrentHashMap, otherwise HashMap. Oh, and this is just food for thought. I'm not affiliated with Netbeans development in any way :) |
Hey @tonihele , right you are.. It's on my radar.. |
matthiasblaesing
approved these changes
Dec 3, 2022
There are a few remaining rawy type List warnings remaining.. This try to clean the bulk of them up. It's been a slog to get all this done.. [repeat] /home/bwalker/src/netbeans/ide/editor/src/org/netbeans/modules/editor/NbEditorKit.java:712: warning: [unchecked] unchecked call to add(E) as a member of the raw type List [repeat] l.add(action); [repeat] ^ [repeat] where E is a type-variable: [repeat] E extends Object declared in interface List
BradWalker
force-pushed
the
cleanup_last_raw_type_list
branch
from
a85b2fd
to
7ac2d78
Compare
pepness
pushed a commit
to pepness/incubator-netbeans
that referenced
this pull request
Jan 9, 2023
There are a few remaining raw type List warnings remaining.. This attempt is to try and clean the bulk of them up. It's been a slog to get all this done.. [repeat] /home/bwalker/src/netbeans/ide/editor/src/org/netbeans/modules/editor/NbEditorKit.java:712: warning: [unchecked] unchecked call to add(E) as a member of the raw type List [repeat] l.add(action); [repeat] ^ [repeat] where E is a type-variable: [repeat] E extends Object declared in interface List The remaining ones are mostly due to generated code. They will require a different type of fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few remaining raw type List warnings remaining.. This attempt is to try and clean the bulk of them up. It's been a slog to get all this done..
[repeat] /home/bwalker/src/netbeans/ide/editor/src/org/netbeans/modules/editor/NbEditorKit.java:712: warning: [unchecked] unchecked call to add(E) as a member of the raw type List
[repeat] l.add(action);
[repeat] ^
[repeat] where E is a type-variable:
[repeat] E extends Object declared in interface List
The remaining ones are mostly due to generated code. They will require a different type of fix.
^Add meaningful description above
By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -
Please make sure (eg.
git log) that all commits have a valid name and email address for you in the Author field.If you're a first time contributor, see the Contributing guidelines for more information.
If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.