Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed some Gradle introspection problems wit pre-6.1 Gradle Versions #5014

Merged
merged 1 commit into from
Nov 27, 2022
Merged

Fixed some Gradle introspection problems wit pre-6.1 Gradle Versions #5014

merged 1 commit into from
Nov 27, 2022

Conversation

lkishalmi
Copy link
Contributor

Yet another fix, restoring some pre-6.1 Gradle Compatibility.

Brief list of the changes:

  • VersionNumber -> GradleVersion (VersionNumber is deprecated for a while)
  • Also comparing on base version, so no comparisons to RCs are needed.
  • Identify plugin by name instead of class
  • Checking for MissingPropertyException-s in getProperty and returning null if that would happen.

I'm still unhappy about the issues caused by the mass auto-discovery feature.

@lkishalmi lkishalmi added the Gradle [ci] enable "build tools" tests label Nov 27, 2022
@lkishalmi lkishalmi added this to the NB17 milestone Nov 27, 2022
sdedic
sdedic approved these changes Nov 27, 2022
View reviewed changes
Copy link
Member

@sdedic sdedic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks. I still lack the cross-version expertise.

matthiasblaesing
matthiasblaesing approved these changes Nov 27, 2022
View reviewed changes
Copy link
Contributor

@matthiasblaesing matthiasblaesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not an expert here, but looks sane. GradleVersion indeed seems to be around since a long time and looks like a save usage here.

@lkishalmi lkishalmi merged commit 1eff472 into apache:master Nov 27, 2022
@lkishalmi lkishalmi mentioned this pull request Nov 27, 2022
Merged
@lkishalmi lkishalmi added 16u1 and removed 16u1 labels Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiasblaesing matthiasblaesing matthiasblaesing approved these changes

@sdedic sdedic sdedic approved these changes

Assignees
No one assigned
Labels
Gradle [ci] enable "build tools" tests
Projects
None yet
Milestone
NB17
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lkishalmi @matthiasblaesing @sdedic