Fix #5015: Fix Gradle/broken task dependency and serialization #5022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdedic
changed the title
|
Note - the failing test is because of #4984, this PR should not have any effect on that test (negative or positive). |
|
@lkishalmi can I merge this before #4984 fix ? |
|
First this should go to master first. then it would be backported (cherry-picked) for NB16u1 as a separate PR. |
lkishalmi
pushed a commit
to lkishalmi/netbeans
that referenced
this pull request
Dec 6, 2022
…pache#5022) * Avoid failing on broken tasks during dependency inspection * Corrected bad check for primitive class that passed also generated proxies (fixes apache#5015)
lkishalmi
pushed a commit
that referenced
this pull request
Dec 6, 2022
lkishalmi
pushed a commit
that referenced
this pull request
Dec 15, 2022
Chris2011
pushed a commit
to Chris2011/netbeans
that referenced
this pull request
Dec 15, 2022
…pache#5022) * Avoid failing on broken tasks during dependency inspection * Corrected bad check for primitive class that passed also generated proxies (fixes apache#5015)
pepness
pushed a commit
to pepness/incubator-netbeans
that referenced
this pull request
Jan 9, 2023
…pache#5022) * Avoid failing on broken tasks during dependency inspection * Corrected bad check for primitive class that passed also generated proxies (fixes apache#5015)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During debugging of #5015, I've also encountered some broken task that depended on a non-existing class: so I wrapped task dependencies into
try-catch(LinkageError).The not serializable bug itself was caused by an improper test for primitive that passed on even some generated proxy with no package. The current version will still pass more values than just primitive wrappers (anything from java.lang).