Support for OCI profiles. #5118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdedic
added
enhancement
LSP
sdedic
force-pushed
the
oci/profiles-audit
branch
from
e9000e0
to
af3c0a9
Compare
…g/netbeans/modules/nbcode/integration/commands/ProjectAuditCommand.java
sdedic
force-pushed
the
oci/profiles-audit
branch
from
af3c0a9
to
640fed1
Compare
|
Some more changes coming, sorry -- @jhorvath suggested offline that the tenancy name should be shown instead of region, asi it probably makes more sense to the user. The tenancy name however need to be fetched from the remote, since OCI profile only contains tenancy OCID |
jhorvath
approved these changes
Jan 3, 2023
| JLabel l = (JLabel)c; | ||
| l.setIcon(ImageUtilities.loadImageIcon("org/netbeans/modules/cloud/oracle/resources/tenancy.svg", false)); | ||
| if (p.isDefaultConfig()) { | ||
| l.setText(Bundle.LBL_DefaultConfigProfile(p.getId(), p.getConfigProvider().getRegion().getRegionId())); |
There was a problem hiding this comment.
I would prefer tenancy name instead of default region here.
sdedic
force-pushed
the
oci/profiles-audit
branch
from
b8f639a
to
e1da482
Compare
|
looks like this one causes the VSCode ext job to fail. We should probably trigger that one with the LSP label too, right? |
This was referenced Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OCI config (
~/.oci/configby default) may contain multiple profiles, each providing a different auth token (= different effective permissions) and/or connecting to a different tenancy in specific region. The current implementation assumed just the default profile for all operations.I've changed the implementation so that:
It is possible to temporarily set an active profile; the settings will be eventually propagated through RequestProcessors tasks initiated by the wrapped execution.
ADM vulnerability scan features now accept profile to run with, and the relevant LSP audit command accepts an optional profile setting.