Fix Javadoc 17 parsing #5127
Merged
Fix Javadoc 17 parsing #5127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neilcsmith-net
added
Java
mbien
reviewed
Dec 20, 2022
java/java.sourceui/test/unit/src/org/netbeans/api/java/source/ui/HTMLJavadocParserTest.java
Outdated
Show resolved
Hide resolved
This comment was marked as resolved.
This comment was marked as resolved.
neilcsmith-net
force-pushed
the
javadoc17-parsing
branch
from
f187879
to
6b70931
Compare
|
Thanks @mbien Yes, aware the tests were disabled. Have added an extra commit to enable with two exclusions. FastIndexTest is failing to access JDK sources. MarkupTagProcessorTest doesn't seem like it ever could have worked - failing equality test on a class that doesn't implement equals(). 🤷 |
|
this PR triggered a bug in CI. If a job times out it counts as cancelled, which makes it think that the user cancelled the workflow and the cleanup job will run which means that we can't restart the timed out job since the workspace artifact is already gone. Sorry about that. |
matthiasblaesing
approved these changes
Dec 27, 2022
|
Thanks for the reviews - merging.
Yes, at some point we could probably do with not parsing HTML5 with an HTML 3.2 parser! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to fix parsing of Javadoc HTML generated by Java 17, which uses
<section>tags, so that documentation shows up in code completion if no source available.Second commit fixes external link format when linking to a constructor or method with multiple parameters.