Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GH-5104] Ensure @use and @forward can be parsed in less files #5142

Merged
merged 2 commits into from
Dec 26, 2022

Conversation

matthiasblaesing
Copy link
Contributor

@use and @forward were parsed as SCSS tokens, which leads to failures in LESS files.

This was most probably introduced by 3a64a84

Closes: #5104

@use and @forward were parsed as SCSS tokens, which leads to failures
in LESS files.

This was most probably introduced by 3a64a84
@matthiasblaesing matthiasblaesing added the CSS [ci] enable web job label Dec 23, 2022
@matthiasblaesing
Copy link
Contributor Author

Copy link
Contributor

@lkishalmi lkishalmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have to admit, that I do not know CSS this much, though the changes looks sane.

@matthiasblaesing
Copy link
Contributor Author

@lkishalmi thank you for the review, @troizet thank you for the test.

@matthiasblaesing matthiasblaesing merged commit 08edf24 into apache:master Dec 26, 2022
@matthiasblaesing matthiasblaesing added this to the NB17 milestone Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CSS [ci] enable web job
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSS: Parsing error "unexpected token SASS_FORWARD" in LESS file
2 participants