move webcommon job to JDK 11 and fix tests where needed. #5143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JsDocCodeCompletionTest can't use getTestFile() in overwritten method since the method fails the test if the file does not exist. The Test file logic in CslTestBase::assertDescriptionMatches has to be able to call exists() on a potentially not existing file when it is trying to find JDK version specific (golden) test files.
mbien
added
the
JavaScript
matthiasblaesing
approved these changes
Dec 24, 2022
|
@matthiasblaesing thanks for review and happy holidays! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
only a single test failed:
JsDocCodeCompletionTestcan't usegetTestFile()in overwritten method since the method fails the test if the file does not exist. The Test file logic inCslTestBase::assertDescriptionMatcheshas to be able to callexists()on a potentially not existing file when it is trying to find JDK version specific (golden) test files.everything else in this job should be ready for 11.
meta issue: #4904