move ide modules job to JDK 11 and fix tests where needed. #5144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- don't test JDK APIs. - JDK 11 fixes: javac path and java.lang.Module classname conflict. - fix WSDLSchemaValidatorTest assertion, some xml validation errors seem to appear twice on newer JDKs.
matthiasblaesing
approved these changes
Dec 24, 2022
| @@ -167,7 +168,13 @@ private void validate(URI uri, int expectedErrorCount) | |||
| assertNotNull(vr.getValidationResult()); | |||
|
|
|||
| ValidationHelper.dumpErrors(vr); | |||
| assertTrue("expect error " + expectedErrorCount, vr.getValidationResult().size() == expectedErrorCount); | |||
|
|
|||
| // some missing element errors appear twice on newer JDKs | |||
There was a problem hiding this comment.
Could reproduce the problem in JDK 19 (17 was ok).
There was a problem hiding this comment.
might depend on the update release version since it is also reproducible on JDK 11 with the zulu distribution:
https://github.com/apache/netbeans/actions/runs/3761176522/jobs/6394078954#step:94:2272
[junit] Testcase: testValidateMessageNoName(org.netbeans.modules.xml.wsdl.validator.WSDLSchemaValidatorTest): FAILED
[junit] expect error 2
[junit] junit.framework.AssertionFailedError: expect error 2
[junit] at org.netbeans.modules.xml.wsdl.validator.WSDLSchemaValidatorTest.validate(WSDLSchemaValidatorTest.java:170)
i vaguely remember that xml libs got an update in OpenJDK, I just don't know the backporting rules for things like that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
meta issue: #4904