CssSemanticAnalyser needs to flatten OffsetRanges for highlights #5151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… ranges are not deteced This case for example: OR1: |--------------| OR2: |---| was not caught.
matthiasblaesing
added
CSS
|
A test build is available from: https://doppel-helix.eu/NetBeans-dev-dev-36a8505c1a01bf5f6f4545b4e078efae31bfd658-release.zip |
|
@matthiasblaesing not sure if you know. But we can now also create test builds by simply adding the
ci:dev-build
|
|
@mbien I knew this in the back of my mind. When it became important, my mind did not want to help in remembering. Thanks for the input! |
CssSemanticAnalyser reported overlapping ranges for highlights, for example when an attribute is used in a :not() pseudo class construct. The formatting behind the embedded range is lost and results in a broken view. The embedded OffsetRanges need to be flattened into a sequenze of non-overlapping ranges. Closes: apache#5012
matthiasblaesing
force-pushed
the
GH-5012
branch
from
36a8505
to
5847f35
Compare
|
Reduced logging verbosity and will merge when unittests come back green |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CssSemanticAnalyser reported overlapping ranges for highlights, for
example when an attribute is used in a :not() pseudo class construct.
The formatting behind the embedded range is lost and results in a
broken view.
The embedded OffsetRanges need to be flattened into a sequenze of
non-overlapping ranges.