Recognize nbjrt: protocol and locate JDK9+ src.zip #5157
Conversation
mbien
added
Java
There was a problem hiding this comment.
please make sure this PR builds again before merge. It wasn't labeled. Most of the java tests did not run. (also for the reviewers, please label PRs before approval :))
added
ci:all-tests
| static SourceForBinaryQueryImplementation2.Result searchUnregisteredPlatform(String binaryRootS) { | ||
| String srcZipS = null; | ||
| String srcZipIn = null; | ||
| if (binaryRootS.startsWith(JAR_FILE)) { | ||
| if (binaryRootS.endsWith(RTJAR_PATH)) { |
There was a problem hiding this comment.
would be good to use standard indentation settings for new code.
There was a problem hiding this comment.
It would help if NetBeans apisupport projects specified the proper indentation settings. Otherwise the source gets formatted by my global defaults (which are set to Google Java standards, not Sun/Oracle now).
Reformatted in 5b0d432
There was a problem hiding this comment.
awesome thanks.
Yeah its probably a good idea to copy a few selected IDE defaults to the project settings. Its probably not worth it though if it has to be set up for every single module, would be too much noise for little gain IMO.
There was a problem hiding this comment.
A project type can provide some default AuxiliarySettings - java.mx.project module is doing that to influence the Eclipse formatter (used for mx projects).
There was a problem hiding this comment.
NetBeans Formatter needs one more level of indirection, as it currently uses the project's auxiliary properties directly. If I had time...
| @@ -82,6 +80,23 @@ public void testUnregisteredPlatform() throws Exception { | |||
| assertNull(result); | |||
| } | |||
|
|
|||
| public void testUnregisteredJDK11Platform() throws Exception { | |||
| File wd = getWorkDir(); | |||
There was a problem hiding this comment.
PlatformSourceForBinaryQueryTest seems to pass OK.
The
PlatformForSourceBinaryQueryclass contains support for so called "unregistered platforms". However it seems that the code hasn't been updated to JDK9+ layout. This PR does that. The previously existing test (for JDK8 layout) has been copied and modified to mimic the layout of JDK9+.