tomcat5: Enable usage of javac release and remove internal class use (fix JDK8 and JDK17+) #5160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthiasblaesing
added
ci:dev-build
|
Test build is available here: https://github.com/apache/netbeans/suites/10100859651/artifacts/492515866 |
mbien
approved these changes
Dec 29, 2022
enterprise/tomcat5/src/org/netbeans/modules/tomcat5/deploy/TomcatManagerImpl.java
Outdated
Show resolved
Hide resolved
…(fix JDK8 and JDK17+) The tomcat5 module used the internal classes: com.sun.org.apache.xml.internal.serialize.OutputFormat com.sun.org.apache.xml.internal.serialize.XMLSerializer to modify the tomcat configuration. For this to work the usage of the javac release option had to be disabled as only exported classes are then accessible. This is done by specifying bootclasspath.prepend. Having this masked a different issue which rendered the tomcat module JDK 9+. The method: URLEncoder#encode(String s, Charset enc) was used, which was introduced with JDK9. The alternative URLEncoder#encode(String s, String enc) can be used as a drop-in replacement. Closes: apache#5134 Closes: apache#5154
…) and enable tomcat unittests
matthiasblaesing
force-pushed
the
GH-5134
branch
from
4f9b2fd
to
0a9ce26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tomcat5 module used the internal classes:
com.sun.org.apache.xml.internal.serialize.OutputFormat
com.sun.org.apache.xml.internal.serialize.XMLSerializer
to modify the tomcat configuration. For this to work the usage of the
javac release option had to be disabled as only exported classes are
then accessible. This is done by specifying bootclasspath.prepend.
Having this masked a different issue which rendered the tomcat module
JDK 9+. The method:
URLEncoder#encode(String s, Charset enc)
was used, which was introduced with JDK9. The alternative
URLEncoder#encode(String s, String enc)
can be used as a drop-in replacement.
Closes: #5134
Closes: #5154