Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary bootclasspath.prepend and reenable CI/CD tests for html.editor #5162

Merged

Conversation

matthiasblaesing
Copy link
Contributor

No description provided.

Copy link
Contributor

@lkishalmi lkishalmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as far as I can tell.
Just being curious, were do we get the JS engine nowadays?

@matthiasblaesing
Copy link
Contributor Author

Thank you for your review.

For JS parsing in the context of editing a fork of graaljs is used. At some point in the past graaljs as used in NetBeans and graaljs as in the JS engine of GraalVM split. In between the GraalVM version switched license to UPL and @jtulach created a backport of the NetBeans support to that version and I added more recent Ecmascript support. It is currently developed here: https://github.com/matthiasblaesing/graaljs-nb. The aim of that fork is not to create a JS engine, only the parser is needed.

For JS execution GraalJS (the full implementation based on truffle and the graal sdk) is present in webcommon/libs.graaljs.

@lkishalmi
Copy link
Contributor

Thank you for the info!

@matthiasblaesing matthiasblaesing merged commit 57e480a into apache:master Dec 29, 2022
@mbien mbien added HTML [ci] enable web job CI Continuous Integration tests labels Dec 30, 2022
@mbien mbien added this to the NB17 milestone Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration HTML [ci] enable web job tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants