Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add displayname for maven POM language and order languages in options dialog #5164

Merged

Conversation

matthiasblaesing
Copy link
Contributor

No description provided.

@matthiasblaesing matthiasblaesing added Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) Maven [ci] enable "build tools" tests Platform [ci] enable platform tests (platform/*) tests ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) labels Dec 29, 2022
@matthiasblaesing matthiasblaesing added this to the NB17 milestone Dec 29, 2022
@matthiasblaesing
Copy link
Contributor Author

@mbien your work on maven pom hints made me look at the options panel, which made me notice the missing display name and I noticed in the past, that ordering the languages could improve usability. So this was the moment to fix this. Could you have a look?

Copy link
Member

@mbien mbien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, the result too!

.github/workflows/main.yml Outdated Show resolved Hide resolved
The languages in the formatting and code completion panels are already
alphabetically sorted by their display name. The comparator is pulled
out of the individual implementations and also used in the folder based
panels.
@matthiasblaesing matthiasblaesing merged commit 7f4b816 into apache:master Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) Maven [ci] enable "build tools" tests Platform [ci] enable platform tests (platform/*) tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants