Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to run missing ref hint in batch mode, but mark it as not having a fix. #5171

Merged
merged 1 commit into from
Jan 5, 2023

Conversation

jlahoda
Copy link
Contributor

@jlahoda jlahoda commented Jan 1, 2023

The MissingRefOutput hint is marked as NO_BATCH, but it might make sense to run it in a batch mode, it just cannot be used to generate fixes in a non-interactive environment. So, marking it as query instead.


^Add meaningful description above

By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -

  • are all your own work, and you have the right to contribute them.
  • are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).

Please make sure (eg. git log) that all commits have a valid name and email address for you in the Author field.

If you're a first time contributor, see the Contributing guidelines for more information.

If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.

@jlahoda jlahoda added the Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) label Jan 1, 2023
@mbien mbien added the hints label Jan 1, 2023
@mbien mbien added this to the NB17 milestone Jan 5, 2023
Copy link
Member

@mbien mbien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense and is also trivial. merging soon to get some PRs in.

@mbien mbien merged commit b37d05e into apache:master Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hints Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants