Include JS implementation for JDK16+ execution environment. #5208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdedic
added
LSP
MartinBalin
approved these changes
Jan 5, 2023
|
We need to release it in a patch release of VSNetBeans (VSIX) 16.0.301 as soon as possible along with #5207 . |
dbalek
approved these changes
Jan 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NBLS does not bundle GraalJS implementation. In JDK16+ Nashorn was removed from the JDK and without JS implementation NBLS is not able to process PAC proxy definitions. That affects all outbound connections from NBLS, such as JDBC or OCI ADM audit requests.
It also affects Apache NB vscode extension: since PAC processing fails and no proxy is detected, NBLS gives misleading info to the user that maven/gradle proxy is misconfigured.