Use default wpad.dat if autoproxy without explicit pacfile location. #5210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinBalin
approved these changes
Jan 5, 2023
|
Put into next VSNetBeans release. |
dbalek
approved these changes
Jan 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows it is possible to enable 'automatic proxy configuration', but leave PAC file location unset - this is even the Windows' default setting. NetBeans in 'system proxy' mode rely on pacfile location to be set, if it is blank, NB defaults to 'direct' connection, which may be wrong.
This PR just defaults to the standard
http://wpad/wpad.datif autoproxy is enabled in the system, but no pacfile location is set.