Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed from code semicolon ;; duplicates #5212

Merged
merged 1 commit into from
Jan 7, 2023
Merged

Removed from code semicolon ;; duplicates #5212

merged 1 commit into from
Jan 7, 2023

Conversation

tbw777
Copy link
Contributor

@tbw777 tbw777 commented Jan 5, 2023

Removed unnecessary characters from code.

Removed unnecessary characters from code.
@mbien mbien added Code cleanup ci:all-tests [ci] enable all tests labels Jan 6, 2023
@mbien mbien added this to the NB17 milestone Jan 6, 2023
@apache apache locked and limited conversation to collaborators Jan 6, 2023
@apache apache unlocked this conversation Jan 6, 2023
@mbien
Copy link
Member

mbien commented Jan 6, 2023

@tbw777 thanks for the cleanup. Since you are a first time contributor I assume that you read the PR template and are willing to contribute this code to the apache foundation.

By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -

    are all your own work, and you have the right to contribute them.
    are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).

@neilcsmith-net
Copy link
Member

@tbw777 yes, thanks for the cleanup PRs.

@mbien as we're less than 2 weeks from freeze and branch for NB17, I intend to punt these forward to NB18 as we've done previously with code cleanup late in the cycle, unless you have other thoughts on any?

@mbien
Copy link
Member

mbien commented Jan 7, 2023

@neilcsmith-net we could get a trivial change like this one in I think. We have to put space between big merges anyway, since project wide cleanups cause a lot of trouble if you do too many at once - most of the issues can be avoided if enough time is given to devs to pull from master.

@tbw777 can you please stop closing PRs and opening new ones which replace them? Simply push again if you have changes to make. Tests were running already and some were reviewed.

@tbw777
Copy link
Contributor Author

tbw777 commented Jan 7, 2023

@mbien
Agree

Copy link
Member

@mbien mbien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good.

@tbw777 thanks and congrats on your first contribution to this project.

@mbien mbien merged commit 40c25f5 into apache:master Jan 7, 2023
@tbw777
Copy link
Contributor Author

tbw777 commented Jan 7, 2023

wow )

@tbw777 tbw777 deleted the semicolon branch January 8, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:all-tests [ci] enable all tests Code cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants