Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apidoc error/warning fix #5216

Merged
merged 1 commit into from
Jan 9, 2023
Merged

Conversation

ebarboni
Copy link
Contributor

@ebarboni ebarboni commented Jan 5, 2023

Hi, this is a split of #4450 very limited as nb17 will be cut soon.
Url are fixed to match the allowed link merged to master via #4969

tag samp and q are not allowed to migrated to code
comment needed to type for generics
header should be used in order so pruned use strong

hope I did understand the api enough

Copy link
Member

@mbien mbien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good stuff, thanks for extracting it from the big one :)

@mbien mbien added the JavaDoc [ci] enable java/javadoc tests and build-javadoc target label Jan 5, 2023
@mbien
Copy link
Member

mbien commented Jan 5, 2023

please note that CI did not build javadoc since the label was added too late

@mbien mbien added this to the NB17 milestone Jan 5, 2023
@mbien mbien added the Platform [ci] enable platform tests (platform/*) label Jan 6, 2023
@ebarboni
Copy link
Contributor Author

ebarboni commented Jan 9, 2023

will merge if ok, needs some attention for the release process

@mbien
Copy link
Member

mbien commented Jan 9, 2023

@ebarboni sure lets merge

@ebarboni ebarboni merged commit cd38f5a into apache:master Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JavaDoc [ci] enable java/javadoc tests and build-javadoc target Platform [ci] enable platform tests (platform/*)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants