Removed double null check with instance operator #5224
Conversation
Sometimes found usage of instance operator with variable superflous check for null. But also there is not only variables. Additional null check performs with map.get() or method() and so on.
|
Clone of #5205 closed PR with code format fix |
There was a problem hiding this comment.
A kind request: next time, please split such huge work into more commits or better more pul requests, e.g. one per cluster. More reviewers can work in parallel, and review of a smaller chunk is less error prone.
Looks good except the one forgotten != null not converted.
| @@ -120,7 +120,7 @@ public PropertyDialogManager( | |||
| if (env != null) { | |||
| Object helpID = env.getFeatureDescriptor().getValue(ExPropertyEditor.PROPERTY_HELP_ID); | |||
|
|
|||
| if ((helpID != null) && helpID instanceof String && (component != null) && component instanceof JComponent) { | |||
| if (helpID instanceof String && (component != null) && component instanceof JComponent) { | |||
There was a problem hiding this comment.
Yet another != null && instanceof :)
There was a problem hiding this comment.
Fixed.
Im entirely agree about task splitting
Sometimes found usage of instance operator with variable superflous check for null. But also there is not only variables. Additional null check performs with map.get() or method() and so on.
Sometimes found usage of instance operator with variable superflous check for null. But also there is not only variables. Additional null check performs with map.get() or method() and so on.
Sometimes found usage of instance operator with variable superflous check for null. But also there is not only variables. Additional null check performs with map.get() or method() and so on.
Sometimes found usage of instance operator with variable superflous check for null. But also there is not only variables. Additional null check performs with map.get() or method() and so on.
There was a problem hiding this comment.
Did just review against the last state 2nd time. No need to further split this one, I see you've already partitioned the next round of code cleanup - thanks !
This is fine by me, but I'd advise that one other reviewer would scan through the changes. As there are so many same-type changes, eyes & brain get tired and may miss something.
|
@sdedic I dont see errors. Who can review? |
|
The |
|
Rerunning all tests finally fixed the tests. |
Sometimes found usage of instance operator with variable superflous check for null. But also there is not only variables. Additional null check performs with map.get() or method() and so on.
Also fixed formatting in org.openide.awt.SplittedPanel.java