Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TOML uses ANTLR4 Lexer Support. #5246

Merged
merged 1 commit into from
Jan 9, 2023
Merged

TOML uses ANTLR4 Lexer Support. #5246

merged 1 commit into from
Jan 9, 2023

Conversation

lkishalmi
Copy link
Contributor

Just taking advantage of #5206,deleting duplicated code.

@lkishalmi lkishalmi added the ANTLR label Jan 9, 2023
@lkishalmi lkishalmi added this to the NB17 milestone Jan 9, 2023
mbien
mbien approved these changes Jan 9, 2023
View reviewed changes
Copy link
Member

@mbien mbien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good cleanup here too!

@lkishalmi lkishalmi merged commit 88c0c39 into apache:master Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbien mbien mbien approved these changes

@matthiasblaesing matthiasblaesing Awaiting requested review from matthiasblaesing

Assignees
No one assigned
Labels
ANTLR
Projects
None yet
Milestone
NB17
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lkishalmi @mbien