Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ANTLR uses ANTLR4 Lexer Support. #5247

Merged
merged 1 commit into from
Jan 9, 2023
Merged

ANTLR uses ANTLR4 Lexer Support. #5247

merged 1 commit into from
Jan 9, 2023

Conversation

lkishalmi
Copy link
Contributor

@lkishalmi lkishalmi commented Jan 9, 2023 •
edited

Just taking advantage of #5206 duplicated code.

Also adding DEFAULT_MODE to the known modes slipped in.

@lkishalmi lkishalmi added the ANTLR label Jan 9, 2023
@lkishalmi lkishalmi added this to the NB17 milestone Jan 9, 2023
@mbien
Copy link
Member

mbien commented Jan 9, 2023

java/languages.antlr has tests but they are not hooked into CI. They look like really quick ones so it would be good to have them running.

@lkishalmi
Copy link
Contributor Author

lkishalmi commented Jan 9, 2023 •
edited

@mbien java/languages.antlr had tests. Those were moved to ide/lexer.antlr4.

@mbien
Copy link
Member

mbien commented Jan 9, 2023

@mbien java/languages.antlr had tests. Those were moved to ide/lexer.antlr4.

i see. I looked at the wrong branch locally by mistake, sorry, All good then.

mbien
mbien approved these changes Jan 9, 2023
View reviewed changes
Copy link
Member

@mbien mbien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good to me. The api refactoring is paying off now.

@lkishalmi lkishalmi merged commit 6f472b5 into apache:master Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbien mbien mbien approved these changes

@matthiasblaesing matthiasblaesing Awaiting requested review from matthiasblaesing

@neilcsmith-net neilcsmith-net Awaiting requested review from neilcsmith-net

Assignees
No one assigned
Labels
ANTLR
Projects
None yet
Milestone
NB17
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lkishalmi @mbien