Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not expose LexerInputCharStream as an API. #5257

Merged
merged 1 commit into from
Jan 9, 2023
Merged

Do not expose LexerInputCharStream as an API. #5257

merged 1 commit into from
Jan 9, 2023

Conversation

lkishalmi
Copy link
Contributor

This one is in response of #5206 (comment)

@matthiasblaesing Thanks for your feedback!

@lkishalmi lkishalmi added the ANTLR label Jan 9, 2023
@lkishalmi lkishalmi added this to the NB17 milestone Jan 9, 2023
@lkishalmi lkishalmi changed the title Do not expose LexerInputCharSteeam as an API. Do not expose LexerInputCharStream as an API. Jan 9, 2023
matthiasblaesing
matthiasblaesing approved these changes Jan 9, 2023
View reviewed changes
Copy link
Contributor

@matthiasblaesing matthiasblaesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no real strong feelings here. If really a breaking change needs to be introduced to the bridge, a second implementation can be added.

@lkishalmi lkishalmi merged commit d1c3913 into apache:master Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbien mbien mbien approved these changes

@matthiasblaesing matthiasblaesing matthiasblaesing approved these changes

Assignees
No one assigned
Labels
ANTLR
Projects
None yet
Milestone
NB17
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lkishalmi @mbien @matthiasblaesing