Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle options UI cleanup (Execution and Appearance panel). #5274

Merged
merged 1 commit into from
Jan 12, 2023

Conversation

mbien
Copy link
Member

@mbien mbien commented Jan 11, 2023

  • consistent gaps and component anchors
  • moved a few options to the global exec group

please note that the before screenshots are actually NB 16 and not master. So they have 1-2 fields less.

before (checkboxes in upper panel are all over the place + panel gaps + some exec options not in the lower panel):
gradle-before

after:
gradle-after5

before (left gaps on checkboxes):
gradle-app-before

after (note: new Maven):
gradle-app-after

@mbien mbien added Gradle [ci] enable "build tools" tests UI User Interface labels Jan 11, 2023
@mbien mbien added this to the NB17 milestone Jan 11, 2023
Copy link
Contributor

@lkishalmi lkishalmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mbien Thanks for this PR. Generally it looks good. I'd leave out the Prefer Maven Projects check box out of Gradle Execution as that is really an IDE behavior.When a folder has pom.xml next to gradle build files, then the GradleProjectFactory let's MavenProjectFactory to take over.

I would put that as a distinct option at the bottom right corner.

@mbien
Copy link
Member Author

mbien commented Jan 11, 2023

@lkishalmi tbh I don't quite like how this looks. Can I wrap this into an "Other Options" panel?
gradle-after2

other options panel:
gradle-after3

@lkishalmi
Copy link
Contributor

Well, I actually like the first new version. The second one looks too much for me.
I'd offer a third option then. Let's create a Maven specific panel and put that option there.

There might be other new options in that area...

@mbien
Copy link
Member Author

mbien commented Jan 11, 2023

another proposal (all checkboxes aligned in left column):
gradle-after4

@swpalmer
Copy link
Contributor

swpalmer commented Jan 11, 2023

The prefer Maven over Gradle option really isn't an option of Maven or Gradle. It needs to be in a more general location, possibly on the general tab, even though (currently) these are Java-related. Shouldn't Ant also be included? We need an order list of how they should be prioritized. Theoretically Gradle projects can support C++ as well so if that was ever pursued things could get messier still.
Also the tab order is a little odd, Ant, Gradle, and Maven are related build systems, they should be grouped together in the tab order. I'm not sure if that is easy to do or if the order is somewhat ad-hoc because everything is a plugin or something like that.

@mbien
Copy link
Member Author

mbien commented Jan 11, 2023

I only wanted to fix some layout issues in the UI, consistent gaps, resizing etc, Moving things around to entirely different option panels would be more than just layout adjustments and something for another PR.

@lkishalmi
Copy link
Contributor

@swpalmer That would be a major re-arch. We should create a Build Tools section in the Options Dialog.

 - consistent gaps and component anchors
 - moved a few options to the global exec group
@mbien
Copy link
Member Author

mbien commented Jan 12, 2023

@lkishalmi updated the after image on the PR with the latest change.

  • added Maven card as suggested and moved the "Prefer Maven" checkbox over
  • kept the left aligned checkboxes of the screenshot above
  • some more tweaking for gap consistency between all cards

Copy link
Contributor

@lkishalmi lkishalmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now.

@mbien mbien merged commit 4ec4cf9 into apache:master Jan 12, 2023
mbien added a commit to mbien/netbeans that referenced this pull request Jan 22, 2023
apache#5274 overlooked an invisible label which is only visible if
an unsupported version is selected in the combo box. This
fixes the layout so that making the label visible does not disturb
other UI components.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gradle [ci] enable "build tools" tests UI User Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants