Prevent NullPointerException when matching filenames in SourceUtils #5279
Conversation
matthiasblaesing
added
Java
There was a problem hiding this comment.
The Match class initialized with a null name would never match anything. This may or may not be intended. Hopefully this doesn't cause silent issues now which don't throw exceptions. cc @jlahoda
but this is probably still a good hotfix so +1 from me.
| if (name.equals(fo.getNameExt())) { | ||
| if (fo.getNameExt().equals(name)) { |
There was a problem hiding this comment.
good that getNameExt() returns empty Strings. This makes it better than the JDK 20 proposal of the Path API which was luckily dropped last minute because of it returning null:
https://bugs.openjdk.org/browse/JDK-8297814
I already had a code inspection for that ready expecting it to be a common bug.
new version is the PR 11545 which might make it into JDK 21 following the same null safe logic
good choice back then @jtulach!
|
Seems to work and is minimally invasive, so lets get this in. |
Closes: #5266