Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Windows Maven parent.relativePath from Mark Herkrath #5282

Merged
merged 1 commit into from
Jan 12, 2023

Conversation

mdeggers
Copy link
Contributor

This is to address a parent.relativePath warning for Maven projects on the Windows platform. The fix was suggested by Mark Herkrath herkrath@googlemail.com and mentioned on the dev mailing list. This fixes #5281


^Add meaningful description above

By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -

  • are all your own work, and you have the right to contribute them.
  • are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).

Please make sure (eg. git log) that all commits have a valid name and email address for you in the Author field.

If you're a first time contributor, see the Contributing guidelines for more information.

If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.

@mbien mbien added the Maven [ci] enable "build tools" tests label Jan 12, 2023
@mbien
Copy link
Member

mbien commented Jan 12, 2023

starting CI with the maven tests enabled.

@apache apache locked and limited conversation to collaborators Jan 12, 2023
@apache apache unlocked this conversation Jan 12, 2023
@mbien mbien requested a review from sdedic January 12, 2023 09:24
@mbien mbien added this to the NB17 milestone Jan 12, 2023
@mbien mbien changed the title Fix for Windows Maven parent.relativePath from Mark Herkrath <herkrat… Fix for Windows Maven parent.relativePath from Mark Herkrath Jan 12, 2023
@mbien mbien added the hints label Jan 12, 2023
@mbien mbien merged commit af5a1da into apache:master Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hints Maven [ci] enable "build tools" tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maven Windows parent.relativePath spurious warning
3 participants