Open projects that correspond to workspace folders. Prevents "do you want to open project ?" questions. #5286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…want to open project ?" questions.
sdedic
added
kind:bug
MartinBalin
approved these changes
Jan 12, 2023
|
Please add also to VSNetBeans_1603 branch |
lbownik
reviewed
Jan 12, 2023
| return; | ||
| } | ||
| ProjectInformation pi = ProjectUtils.getInformation(projects[0]); | ||
| String n = pi.getDisplayName(); |
There was a problem hiding this comment.
lines 1207 - 1213 look like they should belong to ProjectInformation class
There was a problem hiding this comment.
lines 1207 - 1213 look like they should belong to ProjectInformation class
Rather to ProjectUtils; but yes, some "give-me-suitable-project-name-with-all-fallbacks' could be useful, I did this chain of null checks several times already. I'll address in a separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the LSP client added a folder to a workspace, then opened a file, NBLS would ask a question "File XXX is part of project Foo, do you want to open ... ?". Since the containing folder was explicitly adeded the lsp client's user, this question is ... silly.
It was caused by NBLS did not receive/process
didChangeWorkspaceFoldersnotification from the LSP client. On the startup, workspace folders were 'registered' as known and NBLS does not ask "project open question" for files beneath those folders - but when the folders change during NBLS run, the added folders were not 'registered' in the same way.