Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ANTLR based Go Parser module #5287

Merged
merged 1 commit into from
Jan 15, 2023
Merged

Conversation

lkishalmi
Copy link
Contributor

This is a generated Lexer/Parser Library for Go.

I'm going to add another module languages.go soon. Since the discussion on the devops cluster has died off, I'm going to add these into the ide cluster, till we find something better.

@lkishalmi lkishalmi added this to the NB17 milestone Jan 12, 2023
@lkishalmi lkishalmi force-pushed the go.lang branch 2 times, most recently from 9f44f88 to c8f6f4a Compare January 13, 2023 03:00
@lkishalmi
Copy link
Contributor Author

I had to make this module show in auto updates, in order to satisfy the commit validation. I'm going to revert that in the upcoming languages.go PR.

Copy link
Member

@mbien mbien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

although this is using a third party grammar it might be still worth to add a basic test.

@lkishalmi
Copy link
Contributor Author

@mbien Well, it is entirely third-party, just downloaded and generated code. I do not exactly know how, but it seems to be tested on these files: https://github.com/antlr/grammars-v4/tree/master/golang/examples

Copy link
Contributor

@matthiasblaesing matthiasblaesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane to me. I think it would have been better to get this in together with filetype wiring, but still ok.

@lkishalmi lkishalmi merged commit c171415 into apache:master Jan 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants