Adding new action which registers ADB connection #5291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbien
added
LSP
|
added LSP label and restarting tests to enable the right jobs. |
sdedic
requested changes
Jan 13, 2023
enterprise/cloud.oracle/src/org/netbeans/modules/cloud/oracle/actions/AddADBAction.java
Outdated
Show resolved
Hide resolved
| List<CompartmentItem> compartments = CompartmentNode.getCompartments().apply(selectedTenancy.get()); | ||
| selectedCompartment = chooseOneItem(compartments, Bundle.SelectCompartment()); | ||
| } | ||
| Optional<DatabaseItem> selectedDatabase = Optional.empty(); |
There was a problem hiding this comment.
why Optional and not simply DatabaseItem that can be checked for null ?
enterprise/cloud.oracle/src/org/netbeans/modules/cloud/oracle/actions/AddADBAction.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| } | ||
| } else if (ociItems.size() == 1) { |
There was a problem hiding this comment.
Seems that the size() > 0 branch is executed instead of this one ?
enterprise/cloud.oracle/src/org/netbeans/modules/cloud/oracle/actions/AddADBAction.java
Show resolved
Hide resolved
enterprise/cloud.oracle/src/org/netbeans/modules/cloud/oracle/actions/AddADBAction.java
Outdated
Show resolved
Hide resolved
MartinBalin
pushed a commit
that referenced
this pull request
Jan 18, 2023
* Adding new action which registers ADB connection * minor fixes in AddABAction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a new action which registers database connection for ADB from Oracle Cloud