Made ANTLR Token LexerInputCharStream Friendly #5292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkishalmi
force-pushed
the
lexer.antlr4-fixed-token
branch
from
5fb9fb3
to
bb373f4
Compare
matthiasblaesing
approved these changes
Jan 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix makes ANTLR Token
getText()andtoString()methods usable when the lexer is backed byLexerInputCharStream. Unfortunately it seems that ANTLR does not really honor their contract when saying some methods can throwUnsupportedOperationException. I may file a PR for ANTLR as well, till then, this one makes debugging easier.I also dared to change the
AbstractAntlrLexerBridge.mapToken(int antlrTokenType)->AbstractAntlrLexerBridge.mapToken(org.antlr.v4.runtime.Token antlrToken)till it's in this phase. Mappers could take advantage on the full token info as thegetText()method is working.