Proper escaping of TNS_ADMIN path. Select JDBC driver with defined implementation. #5363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdedic
added
VSCode Extension
MartinBalin
previously approved these changes
Jan 25, 2023
lbownik
reviewed
Jan 26, 2023
enterprise/cloud.oracle/src/org/netbeans/modules/cloud/oracle/actions/DownloadWalletAction.java
Outdated
Show resolved
Hide resolved
|
This will be also needed for vsnetbeans, I guess I should rebase to |
|
If it needs to go into NB17, then yes - base branch of PR needs changing to delivery, and commit rebasing on top of delivery if necessary. Also add the milestone when you're ready. |
sdedic
force-pushed
the
oci/wallet-jdbc-selection
branch
from
c074c4f
to
c158a2c
Compare
|
(marked as NB17, will rebase after @jhorvath's review, should be clean) |
jhorvath
previously approved these changes
Jan 26, 2023
enterprise/cloud.oracle/src/org/netbeans/modules/cloud/oracle/actions/DownloadWalletAction.java
Show resolved
Hide resolved
sdedic
force-pushed
the
oci/wallet-jdbc-selection
branch
from
6308873
to
7ce696e
Compare
sdedic
dismissed stale reviews from jhorvath and MartinBalin
The base branch was changed.
|
Rebased onto |
sdedic
added a commit
that referenced
this pull request
Jan 27, 2023
…plementation. (#5363) * Proper escaping of TNS_ADMIN path. Select JDBC driver with defined implementation. * Issue warning if driver w/o code locations is selected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two issues with OCI database support:
The
Download Walletaction writes a JDBC connection string with a pathname in it, but the pathname is not properly escaped. This is not an issue on MacOS / Linux, but on Windows that uses backslashes as dir separators, the backslashes in string content are interpreted as escapes by the JDBC driver, and the resulting path will be broken.Second, the action tries to find the appropriate JDBC driver, but
JDBCDriverManager.getDefault().getDrivers()call may reeturn half-configured drivers, that have no JAR files associated with them. This PR makes the action to prefer such drivers that define jars with the actual driver code.The original behaviour had the effect of selecting a wrong driver, i.e. OracleThin driver (without JARs) was persisted while there was full Oracle jdbc driver present (that was configured with appropriate code jars).