Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Annotated record reformatting fix #5374

Merged
merged 1 commit into from
Jan 27, 2023
Merged

Annotated record reformatting fix #5374

merged 1 commit into from
Jan 27, 2023

Conversation

mbien
Copy link
Member

@mbien mbien commented Jan 27, 2023

fixes #4399 targets delivery

had a hard time figuring out how the Reformatter works since not much is documented there, But the fix turned out to be only a small change. Comparing scanRecord with other methods helped a bit.

@mbien mbien added the Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) label Jan 27, 2023
@mbien mbien added this to the NB17 milestone Jan 27, 2023
@mbien mbien linked an issue Jan 27, 2023 that may be closed by this pull request
Java record formatting with annotation problem #4399
Closed
@mbien mbien requested a review from lkishalmi January 27, 2023 04:15
lkishalmi
lkishalmi approved these changes Jan 27, 2023
View reviewed changes
Copy link
Contributor

@lkishalmi lkishalmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neilcsmith-net
Copy link
Member

Looks good, merging. Thanks.

@neilcsmith-net neilcsmith-net merged commit cfa8c63 into apache:delivery Jan 27, 2023
@mbien mbien mentioned this pull request Feb 25, 2023
Merged
@VictorKwok VictorKwok mentioned this pull request Mar 1, 2023
Closed
@mbien mbien mentioned this pull request Mar 5, 2023
Merged
@mbien mbien mentioned this pull request Nov 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lkishalmi lkishalmi lkishalmi approved these changes

@matthiasblaesing matthiasblaesing Awaiting requested review from matthiasblaesing

@neilcsmith-net neilcsmith-net Awaiting requested review from neilcsmith-net

@dbalek dbalek Awaiting requested review from dbalek

Assignees
No one assigned
Labels
Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form)
Projects
None yet
Milestone
NB17
Development

Successfully merging this pull request may close these issues.

Java record formatting with annotation problem
3 participants
@mbien @neilcsmith-net @lkishalmi