[NETBEANS-4054] Ensuring progress when javac crashes while batch evaluating hints. #5384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neilcsmith-net
added
the
Java
mbien
approved these changes
Jan 29, 2023
Comment on lines
-249
to
+258
| if (parameter.toPhase(Phase.RESOLVED).compareTo(Phase.RESOLVED) < 0) | ||
| if (parameter.toPhase(Phase.RESOLVED).compareTo(Phase.RESOLVED) < 0) { | ||
| if (currentInputList.size() == 1) { | ||
| //the javac crashed while processing the (single) file, we must ensure progress, otherwise infinite loop in processing would happen: | ||
| problems.add(new MessageImpl(MessageKind.WARNING, "An error occurred while processing file: " + FileUtil.getFileDisplayName(parameter.getFileObject()) + ", please see the IDE log for more information.")); | ||
| currentPointer.incrementAndGet(); | ||
| } | ||
|
|
||
| return ; | ||
| } |
There was a problem hiding this comment.
this means that this can't happen when BatchSearch is used on multiple files because it wouldn't reuse javac instances there?
So the only reason it tries again with the same file when Phase.RESOLVED can't be reached is because of a possible OOM situation?
If that is the case we should add some kind of per-file retry counter. while(true) loops are always a bit of a danger zone.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If hints are run on save,
BatchSearchis called on a single file. Normally, if javac would crash duringtoPhase, an exception would be thrown. But, it may happen the existing parser is reused, andtoPhasedoes not throw the exception, and this may be mistaken for an out-of-memory situation, to which the response is to restart the processing. This may then lead to an infinite loop.The proposed change here is to force progress in this situation. javac crash(es) need to be handled separately, of course.
^Add meaningful description above
By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -
Please make sure (eg.
git log) that all commits have a valid name and email address for you in the Author field.If you're a first time contributor, see the Contributing guidelines for more information.
If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.