Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React on both build and compile goals. #5396

Merged

Conversation

sdedic
Copy link
Member

@sdedic sdedic commented Jan 31, 2023

Starting from Micronaut 3.8.x, micronaut plugins configure execution for compile goal rather than for the (now deprecated) build goal of the Graalvm native-image plugin.

This PR allows to detect native compilation in older AND newer project setups. Instead of just build all the 'building' goals are checked: according to the documentation and mvn help:describe:

native:add-reachability-metadata
  Description: (no description available)

native:build
  Description: (no description available)

native:compile
  Description: (no description available)

native:compile-no-fork
  Description: (no description available)

native:generateResourceConfig
  Description: (no description available)

native:generateTestResourceConfig
  Description: (no description available)

native:merge-agent-files
  Description: (no description available)

native:test
  Description: (no description available)

the following should produce a binary:

  • native:build
  • native:compile
  • native:compile-no-fork

Goals in execution config are unprefixed, while in actions, they can (or must?) carry plugin shortcut or prefix, so I check the configured goals against set of triggers that contains both unprefixed and prefixed goal names.

The default goal execution changed in plugin 0.9.14; before that, only build and compile were present. Now build is deprecated in favour of compile-no-fork

@sdedic sdedic added VSCode Extension [ci] enable VSCode Extension tests enterprise [ci] enable enterprise job labels Jan 31, 2023
@sdedic sdedic added this to the NB17 milestone Jan 31, 2023
@sdedic sdedic self-assigned this Jan 31, 2023
@neilcsmith-net neilcsmith-net merged commit 071b9d1 into apache:delivery Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enterprise [ci] enable enterprise job VSCode Extension [ci] enable VSCode Extension tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants