-
Notifications
You must be signed in to change notification settings - Fork 822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prepare NB 19 release cycle for JDK 11. #5852
Conversation
- disable CV tests on JDK 8 - move some more jobs to JDK 11 this configuration would allow us to move new modules like rust/go/hcl to JDK 11 and to upgrade exiting modules, like the maven-indexer apache#4999.
Sorry for the delay with that - https://cwiki.apache.org/confluence/display/NETBEANS/Minimum+JDK+build+and+run+policy |
FWIW, there should be a PR at some point (not necessarily here) that would provide user friendly failure messages when the build or binary is used on an unsupported JDK. |
Well, we've really needed that for the IDE since NetBeans 13! Personally, I would now look to bump the bytecode level in non-API bits of the runtime container. eg. check and fail, and update the error messages, at https://github.com/apache/netbeans/blob/master/platform/o.n.bootstrap/src/org/netbeans/Main.java#L43 If as well as checking for JDK, we updated the bytecode level, it would also allow for removing some reflection in #3386 ? |
java: [ '8' ] | ||
java: [ '11' ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Follow up to brief comment on the Markdown PR. Once we're ready for this, we should also add a new label for PRs that update the Java requirements for any module - "non-optional modules are free to adopt the minimum JDK as they need to." should be part of the review process. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks sane to me.
@neilcsmith-net we have
Upgrade Library
agreed |
I got a thumbs up #5852 (comment) and one approval. So I interpret this as go-ahead -> merging. |
@neilcsmith-net are you ok with the name of the new label? |
@mbien looks good. I don't really mind the name, as long as we have one and all know what it means! 😆 |
@vieiro @lkishalmi I remember from reviews that you both tried to use language level 11 before for rust and similar independent modules. This is now possible. simply mark a PR with
Upgrade JDK
|
@mbien I'm with with language level 8 at the moment. Good to know we can mark things for 11, though. |
see #6054 regarding JDK requirements warning UI |
this configuration would allow us to move new modules like rust/go/hcl to JDK 11 and to upgrade exiting modules, like the maven-indexer #4999.
new NB release policy