Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VSCode: Allow for adding extra modules when building extension vsix package #5865

Merged
merged 1 commit into from
Apr 25, 2023

Conversation

dbalek
Copy link
Contributor

@dbalek dbalek commented Apr 21, 2023

Build script modified to allow for adding extra modules when building extension vsix package (using command: ant build-vscode-ext -Dextra.modules="<regexp>")

@dbalek dbalek added the VSCode Extension [ci] enable VSCode Extension tests label Apr 21, 2023
@dbalek dbalek added this to the NB19 milestone Apr 21, 2023
Copy link
Member

@sdedic sdedic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

Copy link
Contributor

@jlahoda jlahoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@dbalek dbalek merged commit 01e4bb2 into apache:master Apr 25, 2023
35 checks passed
@dbalek dbalek deleted the dbalek/build-nbls-extra-modules branch April 25, 2023 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
VSCode Extension [ci] enable VSCode Extension tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants