Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore setTrace requests #5894

Merged
merged 1 commit into from
Jun 5, 2023
Merged

Conversation

sdedic
Copy link
Member

@sdedic sdedic commented Apr 27, 2023

NBLS currently throws UnsupportedOperationException when vscode option java.trace.server is set to verbose'. The LSP client sends a setTrace` notification to the client which was unimplemented.

After discusson with @dbalek, I've decided to just trash the reques: log verbosity can be (and is) controlled by -J-Dnetbeans.console.logger=true by the vscode extension client and the number of protocol messages that appear in the client's output is quite high already.

@sdedic sdedic added LSP [ci] enable Language Server Protocol tests VSCode Extension [ci] enable VSCode Extension tests labels Apr 27, 2023
@sdedic sdedic added this to the NB19 milestone Apr 27, 2023
@sdedic sdedic requested a review from dbalek April 27, 2023 14:01
@sdedic sdedic self-assigned this Apr 27, 2023
@sdedic sdedic merged commit ab5eb3b into apache:master Jun 5, 2023
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LSP [ci] enable Language Server Protocol tests VSCode Extension [ci] enable VSCode Extension tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants