-
Notifications
You must be signed in to change notification settings - Fork 822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup the use of Double primitive wrapper #5957
Conversation
BradWalker
commented
May 18, 2023
Hey @mbien & @matthiasblaesing , I was having trouble with #5714, so decided to start fressh.. Very sorry to be delayed in responding. Recently I had a death in the family and I'm having "difficulty" re-engaging in things that once provided me with joy. Not to mention, I've noticed that I've started to make "simple" mistakes in both things like this as well as my professional life. But, I'm trying. 8-) So in that regard, I think things are fixed. You might need to give this the once over again. And for that, I apologize. Let's see if we can get this easy task done. Thanks for your help/understanding. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BradWalker no need to apologize. Take the time you need, real life should come first.
Thank you for the update. I left two inline comments. The one in ClassesListController.java
must be fixed, as it breaks the calculation. The other might or might not be fixed.
...er/profiler.heapwalker/src/org/netbeans/modules/profiler/heapwalk/ClassesListController.java
Outdated
Show resolved
Hide resolved
platform/openide.explorer/src/org/openide/explorer/view/NodeTableModel.java
Show resolved
Hide resolved
…n do a better job of handling the coversion from a Double primitive to a Double Object or vice versa. This is an extension of the work done in apache#2498. No tests have been touched as those expressly need to manage the conversion. A couple of places I also cleaned up the Float.
101ac23
to
07033bd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks sane to me. Thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me. I am very sorry to hear about your loss.