[JS] Improve resolving this in ClassElements and in arrow functions #5995
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inside initialisation statements:
this needs to evaluate to the surrounding class, to handle this
correctly, search for the right definition of "this" needs to start
at the surrounding object, not the declaration scope of the wrapping
function.
Before:
After:
In arrow functions this is not redefined, but inherited from the outer
scope. In this sample:
this in the lines with the "Mark" comment is an instance of
Foo
andthus it is always the same bar. The this scanning needs to skip arrow
functions.
Before (notice, that only property under the cursor is highlighted):
After (notice, that now all occurences are marked):
After:
Closes: #5740
Closes: #4376