[NETBEANS-980] Fix Home/End/Up/Down actions in line-wrapped editor #603
Conversation
|
@eirikbakke pls. did you test your feature with the java shell editor ? It does weird things with down/up/begin/end to avoid entering the prompt. Just check if the changes did not break it. |
|
I can test that. Will have to get back to this in a little while... in the middle of another deadline and a laptop switch. |
|
I have now tested Java Shell both with and without the patch; there seems to be no changes in behavior that I have managed to observed (testing Home/End/Up/Down). I also tested the case where the current Java Shell prompt line is in fact being wrapped; no new bugs that I could see are being introduced in this case. Here, Home/End/Up/Down seem to work a little differently than in the regular editor, but that was the case before the patch as well. |
eirikbakke
force-pushed
the
NETBEANS-980
branch
from
ec2b1a2
to
fbccf2b
Compare
|
I rebased (and force-pushed) this pull request since changes in the upstream directory structure caused a merge conflict. I've had the patch enabled (together with #598 ) in both my development IDE and my NetBeans Platform application for about a week now, with no ill effects, so I think both of these pull requests are ready to be merged. |
|
Merging the approved PR. Thank you both for creating + reviewing this. |
See https://issues.apache.org/jira/browse/NETBEANS-980 .
This pull request can be reviewed/merged independently of that for NETBEANS-977, which deals with the specific word breaking policy ( #598 ).