Adding DB configuration provider for NBLS #6058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhorvath
added
LSP
thurka
reviewed
Jun 9, 2023
java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/db/DBConnectionsProvider.java
Outdated
Show resolved
Hide resolved
thurka
reviewed
Jun 9, 2023
java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/db/DBConnectionsProvider.java
Outdated
Show resolved
Hide resolved
|
Java part looks OK to me. |
thurka
approved these changes
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating a method how Database Connection properties are provided to a running application in NBLS. Former one didn't follow best security practices. Plain text password was stored in VSCode settings json. This is now removed with DBSetEnvCommand. New implementation takes it the other way around. DB connection properties are still stored in NB, when VSCode runs an application it asks NBLS for DB connection details (including password) using DBConnectionProvider.