Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multitabs underline at top tab rendering. #6073

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

mbien
Copy link
Member

@mbien mbien commented Jun 13, 2023

this makes it look consistent to regular editor tabs

multitabs code is running when for example sorted-document-list is enabled in:
tools -> options -> appearance -> document tabs -> "Sort opened documents list by default" checkbox

multitabs-rendering-fix

extracted from #4948

this makes it look consitent to regular editor tabs
@mbien mbien added Editor Platform [ci] enable platform tests (platform/*) UI User Interface ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) labels Jun 13, 2023
@mbien mbien added this to the NB19 milestone Jun 13, 2023
Copy link
Member

@neilcsmith-net neilcsmith-net left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good immediate fix for consistency, pending any further rendering enhancements that @eirikbakke mentioned. Thanks!

@mbien mbien merged commit 2ad408e into apache:master Jun 14, 2023
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) Editor Platform [ci] enable platform tests (platform/*) UI User Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants