Adding ability to edit database connection properties in VSCode extension #6079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhorvath
added
Need Squashing
LSP
dbalek
approved these changes
Jun 15, 2023
Ondrej-Douda
force-pushed
the
odouda/GCN-1801/Properties
branch
from
58e1a9a
to
b0585d7
Compare
jhorvath
force-pushed
the
odouda/GCN-1801/Properties
branch
from
bea676c
to
b0585d7
Compare
Ondrej-Douda
force-pushed
the
odouda/GCN-1801/Properties
branch
2 times, most recently
from
2b80506
to
d0a0a62
Compare
sdedic
reviewed
Jun 16, 2023
| "unknown": unknown | ||
| }; | ||
| export type Property<T extends keyof PropTypeMap = keyof PropTypeMap> = T extends T ? { | ||
| propPref: boolean; |
There was a problem hiding this comment.
why all the prop prefixes ? Inconsistent naming: dispName vs. shortName
There was a problem hiding this comment.
This is taken from return type of NBLS command...
...ava.lsp.server/src/org/netbeans/modules/java/lsp/server/explorer/NodePropertiesProvider.java
Show resolved
Hide resolved
...ava.lsp.server/src/org/netbeans/modules/java/lsp/server/explorer/NodePropertiesProvider.java
Show resolved
Hide resolved
...ava.lsp.server/src/org/netbeans/modules/java/lsp/server/explorer/NodePropertiesProvider.java
Show resolved
Hide resolved
| if (propJson instanceof JsonNull) { | ||
| return CompletableFuture.completedFuture(null); | ||
| } | ||
| List m = gson.fromJson((JsonElement) propJson, List.class); |
There was a problem hiding this comment.
Hm ... could be more friendly if the property sets was a map (keyed by set name) instead of array, but the propset name is present in each array's item, so it's probably OK.
Maybe if
List<Map<String, Object>> m = ...
the setAllProperties and others can use strongly typed Map instead of raw type(s) ?
| prop.setValue(val); | ||
| } | ||
| } catch (IllegalAccessException ex) { | ||
| Exceptions.printStackTrace(ex); |
There was a problem hiding this comment.
Maybe there could be a way how to report a failed set to the client.
sdedic
requested changes
Jun 16, 2023
Ondrej-Douda
force-pushed
the
odouda/GCN-1801/Properties
branch
4 times, most recently
from
df183a2
to
b50d9b3
Compare
Ondrej-Douda
force-pushed
the
odouda/GCN-1801/Properties
branch
3 times, most recently
from
ad3bce5
to
b6b06dc
Compare
sdedic
approved these changes
Jun 22, 2023
thurka
force-pushed
the
odouda/GCN-1801/Properties
branch
from
b6b06dc
to
d1f4a1a
Compare
|
please don't merge PRs without squashing them properly. Not sure what happened here, e.g the merge commit is missing which makes it difficult to track commits back to their PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding ability to open property sheet of database connection in VSCode extension.