Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Oracle Autonomous DB - Select Compartment #6103

Merged
merged 1 commit into from
Jun 23, 2023
Merged

Conversation

thurka
Copy link
Contributor

@thurka thurka commented Jun 20, 2023

If you clicked the Add Oracle Autonomous DB, selected oraclelabs tenancy & gcn-dev compartment. Select Database quick pick is now displayed, which actually shows another compartments. This view should actually show a mixed list of databases and nested compartments. There's no way to identify whether an entry represents a compartment or database. This fix displays a flat list of all compartments using fully qualified names in the Select Compartment quick pick to select the compartment in a single step, the same way as used in the GCN ext. This way the following Select Database quick pick can really display just databases.

@thurka thurka added LSP [ci] enable Language Server Protocol tests VSCode Extension [ci] enable VSCode Extension tests labels Jun 20, 2023
@thurka thurka requested a review from jhorvath June 20, 2023 14:51
@thurka thurka self-assigned this Jun 20, 2023
@apache apache locked and limited conversation to collaborators Jun 21, 2023
@apache apache unlocked this conversation Jun 21, 2023
Copy link
Contributor

@jhorvath jhorvath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@thurka thurka merged commit 4b15b95 into apache:master Jun 23, 2023
67 of 68 checks passed
@thurka thurka deleted the GCN-1395 branch June 23, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LSP [ci] enable Language Server Protocol tests VSCode Extension [ci] enable VSCode Extension tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants