Fix some compiler warnings and did some cleanups for module j2ee.core
#6118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asbachb
force-pushed
the
web.core-unchecked
branch
from
efceaae
to
fef4fd8
Compare
enterprise/web.core/src/org/netbeans/modules/web/wizards/AttrDialog.java
Show resolved
Hide resolved
enterprise/web.core/src/org/netbeans/modules/web/jspcompiler/SmapResolver.java
Outdated
Show resolved
Hide resolved
enterprise/web.core/src/org/netbeans/modules/web/jspcompiler/SmapResolver.java
Outdated
Show resolved
Hide resolved
enterprise/web.core/src/org/netbeans/modules/web/core/palette/items/IfCustomizer.java
Outdated
Show resolved
Hide resolved
enterprise/web.core/src/org/netbeans/modules/web/core/palette/items/IfCustomizer.java
Outdated
Show resolved
Hide resolved
enterprise/web.core/src/org/netbeans/modules/web/core/jsploader/JspDataObject.java
Outdated
Show resolved
Hide resolved
asbachb
force-pushed
the
web.core-unchecked
branch
2 times, most recently
from
c0cc17c
to
dab0eed
Compare
|
Looks sane to me. Lets see what the CI/CD run has to say. Before the final merge, please check if it would make sense to squash all changes into a single commit or if they should be kept separate. |
* Using generic types to get rid of `unchecked` warnings * Replacing deprecated calls with suggested alternatives Minor code improvements: * Removing unused imports * Removing unused and commented out code (not touched since years) * Removed empty if statement and unnecessary double braces * Adding missing `@Override` annotation
asbachb
force-pushed
the
web.core-unchecked
branch
from
dab0eed
to
62d04cf
Compare
|
Normally I try to separate logical blocks per commit to have some kind of developer diary. |
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looked at console output during build and tried to fix some warnings.