Added basic line indenting to HCL languages. #6127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Looks mostly sane to me. I have one problem with this: It introduces trailing whitespace on empty lines. I noticed this when I tested this with the example.tf file. It looked (and is) well indented, yet the file becomes modified, because the empty lines in the blocks get space injected.
ide/languages.hcl/src/org/netbeans/modules/languages/hcl/BasicHCLLexer.java
Outdated
Show resolved
Hide resolved
|
Thanks for reporting that! I'm working on some tests, as some of the (edge) cases might be not handled well. And now I wish we have Java 17 Textblocks... |
lkishalmi
force-pushed
the
languages.hcl-indent
branch
from
a115ad9
to
9de8441
Compare
matthiasblaesing
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making HCL editing a bit easier...