Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various improvements to "Open in System" action #6159

Merged
merged 3 commits into from
Jul 7, 2023

Conversation

neilcsmith-net
Copy link
Member

@neilcsmith-net neilcsmith-net commented Jul 6, 2023

As discussed in #6043 , various minor improvements to SystemOpenAction- add a default shortcut (SO-S), add to editor tab actions, and filter out .shadow files from list.

Stops the shadow text file being opened along with a folder in the Favorites window.
Slight change in existing Windows-only behaviour to only exclude the problematic files from the list.
@neilcsmith-net neilcsmith-net added this to the NB19 milestone Jul 6, 2023
@neilcsmith-net neilcsmith-net requested a review from mbien July 6, 2023 16:40
Copy link
Member

@mbien mbien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@ActionReference(path = "UI/ToolActions/Files", position = 2045),
@ActionReference(path = "Projects/Actions", position = 101)
@ActionReference(path = "Projects/Actions", position = 101),
@ActionReference(path = "Shortcuts", name = "SO-S")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SOS?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, hadn't thought that that's what ALT-SHIFT-S would be until working on the PR. 😄 Made sense before as similar to the terminal / copy path actions, with S for system (and O is taken).

@neilcsmith-net neilcsmith-net merged commit 325c6d5 into apache:master Jul 7, 2023
34 checks passed
@neilcsmith-net neilcsmith-net deleted the gh6043-1 branch January 16, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants