Make NP Dereference hint aware of Objects.requireNonNull(). #6195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Method checked against getDescription() instead of toString() as the doc specifies, which made this assert essentially a no-op. The method assertContainsWarnings() does also check against toString().
mbien
added
Java
mbien
force-pushed
the
dereference-hint-requirenonnull
branch
from
1e131bb
to
0498a03
Compare
|
panning to merge this too on Sunday before freeze. Is a fairly low risk fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit is fixing the test framework itself since some tests were using the
assertNotContainsWarningswrong.assertContainsWarningschecks againsttoString()which is the full error state, including line number and position.assertNotContainsWarningsis only checkinggetDescription(), but the doc was copied fromassertContainsWarningswhich means that all tests which actually followed the doc, didn't verify anything.second commit makes the NPECheck hint
Objects.requireNonNullaware.fixes #6149