Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the currently active dialog as the presenter parent #6216

Merged
merged 3 commits into from
Jul 18, 2023
Merged

Use the currently active dialog as the presenter parent #6216

merged 3 commits into from
Jul 18, 2023

Conversation

neilcsmith-net
Copy link
Member

@neilcsmith-net neilcsmith-net commented Jul 18, 2023 •
edited

Updates to #5989 by @rkeen-siemens to address comments and to check tests before we branch for NB19.

Fixes #5987

rkeen-siemens and others added 3 commits July 14, 2023 14:03
@rkeen-siemens
apache#5987: Use the currently active dialog as the presenter parent.
d1ac397
@neilcsmith-net
Merge branch 'rk/5987/dialog-parent' of https://github.com/rkeen-siem…
e9d3df1 
…ens/incubator-netbeans into rk-dialog-parent
@neilcsmith-net
Update dialog parent API, displayer impl and test.
d7474cf 
Update Utilities findDialogParent API to not use fallback Supplier and update docs.
Update DialogDisplayerImpl to validate preferred parent.
Update DialogDisplayerImplTest to stop stray modal dialog breaking parent test.
@neilcsmith-net neilcsmith-net added the ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) label Jul 18, 2023
@neilcsmith-net neilcsmith-net mentioned this pull request Jul 18, 2023
Merged
@neilcsmith-net neilcsmith-net added this to the NB19 milestone Jul 18, 2023
@neilcsmith-net neilcsmith-net added the Platform [ci] enable platform tests (platform/*) label Jul 18, 2023
@apache apache locked and limited conversation to collaborators Jul 18, 2023
@apache apache unlocked this conversation Jul 18, 2023
@neilcsmith-net neilcsmith-net changed the title Update dialog parent PR Use the currently active dialog as the presenter parent Jul 18, 2023
@neilcsmith-net neilcsmith-net merged commit 8df65b7 into apache:master Jul 18, 2023
65 of 68 checks passed
mbien
mbien reviewed Jul 18, 2023
View reviewed changes
Copy link
Member

@mbien mbien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes make sense to me. Although I have limited experience with the window parent issue.

This was referenced Aug 3, 2023
Closed
Closed
Merged
@neilcsmith-net neilcsmith-net deleted the rk-dialog-parent branch January 16, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbien mbien mbien left review comments

Assignees
No one assigned
Labels
ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) Platform [ci] enable platform tests (platform/*)
Projects
None yet
Milestone
NB19
Development

Successfully merging this pull request may close these issues.

Modal dialog with wrong parent can lock up the application
3 participants
@neilcsmith-net @mbien @rkeen-siemens