New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prefixing all code names of commands with 'nbls'. #6218
Prefixing all code names of commands with 'nbls'. #6218
Conversation
@lahodaj please use the GitHub account tied to your ASF membership. Commit email should ideally be tied to that too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me.
cbb6f97
to
f6e7f94
Compare
f6e7f94
to
96e50f5
Compare
Approved, thank you for making this change |
@neilcsmith-net, it would be awesome if this could be included in NB 20. I am sorry I am late, but there's unfortunately only a small window in which we can get this patch in (as it will break some outside components, so it is necessary give them time to adjust), and I unfortunately was not able to finish this in the past 2-3 weeks. Thanks for your consideration! |
@lahodaj not my call to make. cc./ @MartinBalin Everything not in by branch just gets automatically bumped to the next milestone. Whether it belongs in delivery is then up to review. As there is almost nothing here touching code outside of LSP then he's best placed on the release team to oversee that. See also https://cwiki.apache.org/confluence/display/NETBEANS/Pull+requests+for+delivery There appears to be git merge conflict text included here! |
96e50f5
to
5ef2d77
Compare
5ef2d77
to
b6dc0d4
Compare
@neilcsmith-net OK to merge, or do you do merging to delivery? (Sorry, the process is not completely clear to me.) Thanks! |
@lahodaj someone on the release team will merge. We handle all merging to delivery. It's just not our call (any more than any other reviewer) what should be included. Key line from the wiki page above - "The release team handles all merging to delivery. The release team does not control what gets merged. All pull requests for delivery that pass review will be merged for the next release candidate if there is one." This will get merged for 20-rc2, but not immediately. First priority is to get a fix in for that fact that the VSCode plugin isn't buildable from the release bundle - see comment on #6417 |
Another attempt to get:
#6015
Adding support for changing the prefix of code names of commands and configuration options from on the client extension.
^Add meaningful description above
By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -
Please make sure (eg.
git log
) that all commits have a valid name and email address for you in the Author field.If you're a first time contributor, see the Contributing guidelines for more information.
If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.